Skip to content

Report discarded log in batch processor as log_byte #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adinauer wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Report discarded log in batch processor as log_byte #4971

adinauer wants to merge 4 commits into from
+3 −2

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Dec 18, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

adinauer
adinauer commented Dec 18, 2025
View reviewed changes
sentry/src/main/java/io/sentry/logger/LoggerBatchProcessor.java
options
.getClientReportRecorder()
.recordLostEvent(DiscardReason.QUEUE_OVERFLOW, DataCategory.Attachment, lostBytes);
.recordLostEvent(DiscardReason.QUEUE_OVERFLOW, DataCategory.LogByte, lostBytes);
Copy link
Member Author

@adinauer adinauer Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a test for this

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 310.69 ms 372.63 ms 61.95 ms
Size 1.58 MiB 2.20 MiB 633.89 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
abfcc92 309.54 ms 380.32 ms 70.78 ms
fcec2f2 357.47 ms 447.32 ms 89.85 ms
bbc35bb 298.53 ms 372.17 ms 73.64 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
d15471f 315.20 ms 370.22 ms 55.02 ms
b77456b 393.26 ms 441.10 ms 47.84 ms
d15471f 310.26 ms 377.04 ms 66.78 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
fc5ccaf 279.11 ms 353.34 ms 74.23 ms
d15471f 286.65 ms 314.68 ms 28.03 ms

App size

Revision Plain With Sentry Diff
abfcc92 1.58 MiB 2.13 MiB 557.31 KiB
fcec2f2 1.58 MiB 2.12 MiB 551.50 KiB
bbc35bb 1.58 MiB 2.12 MiB 553.01 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
b77456b 1.58 MiB 2.12 MiB 548.11 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
fc5ccaf 1.58 MiB 2.13 MiB 557.54 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB

Previous results on branch: adinauer-patch-1

Startup times

Revision Plain With Sentry Diff
07fdf4b 311.86 ms 358.65 ms 46.79 ms

App size

Revision Plain With Sentry Diff
07fdf4b 1.58 MiB 2.13 MiB 559.52 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romtsn romtsn romtsn approved these changes

@markushi markushi Awaiting requested review from markushi markushi is a code owner

@lcian lcian Awaiting requested review from lcian lcian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @romtsn